Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for ToolMaterial & ToolItem classes #3344

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Add documentation for ToolMaterial & ToolItem classes #3344

merged 5 commits into from
Sep 1, 2023

Conversation

Draylar
Copy link
Contributor

@Draylar Draylar commented Oct 22, 2022

ToolMaterial, ToolMaterials, and ToolItem documentation. I was able to duplicate a bit between this & the ArmorMaterial PR, so if any feedback is left on either PR for those methods, I will change it on both PRs. Thanks!

apple502j
apple502j reviewed Oct 22, 2022
View reviewed changes
Copy link
Contributor

@apple502j apple502j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline return maybe?

@liach liach added the javadoc A PR that adds or refactors javadoc. label Nov 1, 2022
@YanisBft YanisBft added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

🚀 Target branch has been updated to 22w43a

@github-actions github-actions bot changed the base branch from 22w42a to 22w43a November 2, 2022 10:54
@modmuss50 modmuss50 removed the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Nov 21, 2022
@Juuxel Juuxel added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Dec 11, 2022
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 1.19.3

@github-actions github-actions bot changed the base branch from 22w43a to 1.19.3 December 11, 2022 11:22
@Juuxel Juuxel added release A PR that targets a release version of Minecraft and removed update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Dec 11, 2022
@Juuxel Juuxel added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Jul 20, 2023
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 1.20.1

@github-actions github-actions bot changed the base branch from 1.19.3 to 1.20.1 July 20, 2023 18:15
@github-actions
Copy link
Contributor

🚨 Unable to automatically update branch with the latest changes

@github-actions github-actions bot removed the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Jul 20, 2023
@YanisBft YanisBft changed the base branch from 1.20.1 to 23w35a September 1, 2023 04:39
@YanisBft YanisBft added snapshot A PR that targets a snapshot version of Minecraft and removed release A PR that targets a release version of Minecraft labels Sep 1, 2023
@apple502j apple502j merged commit cd6aaaa into FabricMC:23w35a Sep 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanisBft YanisBft YanisBft approved these changes

@apple502j apple502j apple502j approved these changes

Assignees
No one assigned
Labels
javadoc A PR that adds or refactors javadoc. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Draylar @YanisBft @apple502j @modmuss50 @Juuxel @liach